Bug 258869 - [MSE] Reuse "fudge factor" when samples are removed
Summary: [MSE] Reuse "fudge factor" when samples are removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Przemyslaw Gorszkowski
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-05 01:35 PDT by Przemyslaw Gorszkowski
Modified: 2023-07-27 07:22 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Gorszkowski 2023-07-05 01:35:06 PDT 
Currently when TrackBuffer::removeSamples is called and erasedRanged is created from the samples, removing small gaps between samples are not done. It causes that in some cases many separated ranges are created which has impact on performance of removing samples.

It can be fixed in similar way as it is done in SourceBufferPrivate::processMediaSample when range is extended with new sample and "fudge factor" is used to eliminate the small gaps between samples.
Comment 1 Przemyslaw Gorszkowski 2023-07-10 04:11:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15690
Comment 2 Radar WebKit Bug Importer 2023-07-12 01:36:18 PDT 
<rdar://problem/112126969>
Comment 3 EWS 2023-07-27 07:22:00 PDT 
Committed 266357@main (c3bf8dd55448): <https://commits.webkit.org/266357@main>

Reviewed commits have been landed. Closing PR #15690 and removing active labels.