Bug 258968 - [run-benchmark] Linux driver executes the browser capturing stdout/stderr but never checks it
Summary: [run-benchmark] Linux driver executes the browser capturing stdout/stderr but...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-07 04:52 PDT by Carlos Alberto Lopez Perez
Modified: 2023-07-07 07:13 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2023-07-07 04:52:25 PDT 
On the Linux driver of run-benchmark there is a bug in the way that the browser is executed.

It uses python subprocess.Popen() capturing stdout and stederr to a pipe, but then that pipe is never checked because the browser is not expected to end.

So if the browser outputs lot of lines either to stdout or stderr it will cause the pipe to become full and then the browser process will get frozen.


I reported this originally at https://github.com/Igalia/cog/issues/589 thinking it was a bug on Cog, but is a bug on the tool used to run the browser.
Comment 1 Carlos Alberto Lopez Perez 2023-07-07 05:29:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15628
Comment 2 EWS 2023-07-07 07:13:00 PDT 
Committed 265839@main (0f3437e25ccf): <https://commits.webkit.org/265839@main>

Reviewed commits have been landed. Closing PR #15628 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-07-07 07:13:18 PDT 
<rdar://problem/111906728>