Bug 259097 - Fix clang-cl warnings for JavaScriptCore Windows port
Summary: Fix clang-cl warnings for JavaScriptCore Windows port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 171618
  Show dependency tree / graph
 
Reported: 2023-07-11 00:03 PDT by Fujii Hironori
Modified: 2023-07-11 01:56 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2023-07-11 00:03:51 PDT 
C:\home\webkit\gc\Source\JavaScriptCore\tools/JSDollarVM.cpp(2854,13): warning: unused function 'callWithStackSizeProbeFunction' [-Wunused-function]
static void callWithStackSizeProbeFunction(Probe::State* state)
            ^
C:\home\webkit\gc\Source\JavaScriptCore\jsc.cpp(3611,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
}
^
C:\home\webkit\gc\Source\JavaScriptCore\jsc.cpp(3079,24): warning: unused variable 'waitToExit' [-Wunused-variable]
static BinarySemaphore waitToExit;
                       ^
Comment 1 Fujii Hironori 2023-07-11 00:08:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15729
Comment 2 EWS 2023-07-11 01:55:11 PDT 
Committed 265941@main (124bb51866f9): <https://commits.webkit.org/265941@main>

Reviewed commits have been landed. Closing PR #15729 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-07-11 01:56:17 PDT 
<rdar://problem/112066657>