RESOLVED FIXED259116
[GLIB] Update env var used to disable using flatpak to build 
https://bugs.webkit.org/show_bug.cgi?id=259116
Summary [GLIB] Update env var used to disable using flatpak to build
Patrick Griffis
Reported 2023-07-11 10:53:03 PDT
This env var is more clear in its purpose. WKDEV_SDK was used by another script but was never an ideal choice.
Attachments
Add attachment proposed patch, testcase, etc.
Patrick Griffis
Comment 1 2023-07-11 10:53:39 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15748
EWS
Comment 2 2023-07-11 11:37:23 PDT
Committed 265955@main (c66b20b0eff6): <https://commits.webkit.org/265955@main> Reviewed commits have been landed. Closing PR #15748 and removing active labels.
Diego Pino
Comment 3 2024-09-06 03:53:09 PDT
The expression is not entirely correct, since `WEBKIT_BUILD_USE_SYSTEM_LIBRARIES=0` also works. Perl's `defined` checks whether a variable exists. To make the expression only work when `WEBKIT_BUILD_USE_SYSTEM_LIBRARIES=1`, it's also necessary to check its value is true.
Diego Pino
Comment 4 2024-09-06 03:53:39 PDT
Re-opening for pull request https://github.com/webkit/webkit/pull/33236
Diego Pino
Comment 5 2024-09-10 01:25:32 PDT
This follow-up eventually landed via https://github.com/WebKit/WebKit/pull/33237
Note You need to log in before you can comment on or make changes to this bug.