Bug 259135 - [Curl][Soup] Move unused function of CredentialStorage[Curl|Soup] to CredentialStorage
Summary: [Curl][Soup] Move unused function of CredentialStorage[Curl|Soup] to Credenti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-11 20:38 PDT by Kenji Shukuwa
Modified: 2023-07-12 00:41 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenji Shukuwa 2023-07-11 20:38:32 PDT 
CredentialStorage::getFromPersistentStorage is not used in WebKit2.
That's why the curl and soup ports have minimal implementations.

Since this function is unlikely to change in the future, we would like
to move the function to CredentialStorage.cpp for better maintainability
in the future.
Comment 1 Kenji Shukuwa 2023-07-11 20:49:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15769
Comment 2 EWS 2023-07-12 00:40:51 PDT 
Committed 265988@main (fea01c276de6): <https://commits.webkit.org/265988@main>

Reviewed commits have been landed. Closing PR #15769 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-07-12 00:41:17 PDT 
<rdar://problem/112124865>