Bug 259146 - Stop using Number.prototype.toLocaleString() for numeric console format specifiers
Summary: Stop using Number.prototype.toLocaleString() for numeric console format speci...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
: 259703 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-07-12 08:17 PDT by Dominic Farolino
Modified: 2023-08-01 13:36 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Farolino 2023-07-12 08:17:05 PDT 
As Devin pointed out in https://github.com/whatwg/console/pull/224#issuecomment-1631837532, it would be best to not use this for numeric format specifiers, since `console.log(1000)` should probably print the same as `console.log('%i', 1000)`.
Comment 1 Devin Rousso 2023-07-12 10:34:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15782
Comment 2 EWS 2023-07-12 18:58:45 PDT 
Committed 266020@main (ae256c9a88db): <https://commits.webkit.org/266020@main>

Reviewed commits have been landed. Closing PR #15782 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-07-12 18:59:16 PDT 
<rdar://problem/112170843>
Comment 4 Devin Rousso 2023-08-01 13:36:31 PDT 
*** Bug 259703 has been marked as a duplicate of this bug. ***