Bug 259172 - Wide-layout attachment baseline: Ensure it's relative to the border box
Summary: Wide-layout attachment baseline: Ensure it's relative to the border box
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gerald Squelart
URL:
Keywords: InRadar
Depends on: 258868
Blocks:
  Show dependency tree / graph
 
Reported: 2023-07-12 20:54 PDT by Gerald Squelart
Modified: 2023-07-12 20:54 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Squelart 2023-07-12 20:54:09 PDT 
Bug 258868 changed the baseline computation to just using `height`s, which may be slightly incorrect.

sgill26 said in https://github.com/WebKit/WebKit/pull/15558#discussion_r1254875925 :
One thing I'm wondering is if we should be using the margin box for the renderer here? I was looking at the other implementations of baselinePosition and they all see to return a value in terms of the margin box, but here we are using the border box.
Comment 1 Radar WebKit Bug Importer 2023-07-12 20:54:20 PDT 
<rdar://problem/112175434>