WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
259244
Don't read 'm_bitMasks' when it's not supposed to be meaningful
https://bugs.webkit.org/show_bug.cgi?id=259244
Summary
Don't read 'm_bitMasks' when it's not supposed to be meaningful
Ahmad Saleem
Reported
2023-07-15 10:07:09 PDT
Hi Team, This is just merge of following:
https://src.chromium.org/viewvc/blink?view=revision&revision=193289
It is partial merge that we don't have implemented other change, where we have to get rid of stuff. It is just initialization optimization to initiate 'm_bitMasks' in applicable case (i.e., less than 16). WebKit Source:
https://github.com/WebKit/WebKit/blob/3a311fd2cd7e267ba71dca49060ad2c6be31f36d/Source/WebCore/platform/image-decoders/bmp/BMPImageReader.cpp#L103
This: if ((m_andMaskState == NotYetDecoded) && !m_buffer->hasAlpha() && (m_infoHeader.biBitCount < 16)) { It compiles. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug