Bug 259256 - [IFC] Available space on main axis computation should use "main size"
Summary: [IFC] Available space on main axis computation should use "main size"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-15 21:05 PDT by zalan
Modified: 2023-07-16 20:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.27 KB, patch)
2023-07-15 21:09 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (5.27 KB, patch)
2023-07-16 15:52 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-07-15 21:05:41 PDT 
ssia
Comment 1 zalan 2023-07-15 21:09:54 PDT 
Created attachment 467056 [details]
Patch
Comment 2 Antti Koivisto 2023-07-16 10:04:42 PDT 
Comment on attachment 467056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467056&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:130
> -                if (!style.minHeight().isSpecified())
> +                if (style.minHeight().isSpecified())

OOPS
Comment 3 zalan 2023-07-16 15:52:43 PDT 
Created attachment 467057 [details]
[fast-cq]Patch
Comment 4 EWS 2023-07-16 20:43:39 PDT 
Committed 266094@main (7707bd0020f8): <https://commits.webkit.org/266094@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467057 [details].
Comment 5 Radar WebKit Bug Importer 2023-07-16 20:44:17 PDT 
<rdar://problem/112376836>