Bug 259260 - Remove 'didChangeScrollOffset' from RenderLayerScrollableArea::scrollTo()
Summary: Remove 'didChangeScrollOffset' from RenderLayerScrollableArea::scrollTo()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-16 03:45 PDT by Ahmad Saleem
Modified: 2023-07-20 15:23 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-07-16 03:45:08 PDT 
Hi Team,

While going through Blink's commit, I came across one revert change of bug 110673.

^ @Simon's reviewed patch landed in above as following: http://trac.webkit.org/changeset/146260

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=148242

WebKit's Source https://github.com/WebKit/WebKit/blob/638ac8184b3860aafc3d68fec13300730af06a6d/Source/WebCore/rendering/RenderLayerScrollableArea.cpp#L424

_______

It was revert because of following:

"This is simply wrong. Something scrolled != the frame scrolled.
Actually RenderLayer can be anything but the frame."

_______

I reverted it locally and it compiles. (Not run 'run-webkit-tests' because I have other scrolling patches as well).

_________

So I just wanted to raise and get input, whether we can remove it as well.

Thanks!
Comment 1 Simon Fraser (smfr) 2023-07-17 11:53:38 PDT 
We can't just remove this. It's a signal that's propagated out to the UI process in WebKit2 (thought I'm not sure what responds to it).
Comment 2 Ahmad Saleem 2023-07-20 15:23:13 PDT 
Marking Invalid based on Simon's comment.