Bug 259284 - SQLiteDatabase::turnOnIncrementalAutoVacuum() is broken
Summary: SQLiteDatabase::turnOnIncrementalAutoVacuum() is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
: 259312 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-07-17 11:37 PDT by Adrien Destugues
Modified: 2023-07-18 14:28 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien Destugues 2023-07-17 11:37:12 PDT 
See the patch here: https://github.com/haiku/haikuwebkit/commit/c8f63951a5f3d5acfd7c40d1606f830272ad791b

This problem already existed a long time ago and was fixed in https://bugs.webkit.org/show_bug.cgi?id=229886

But then it was broken again in https://bugs.webkit.org/show_bug.cgi?id=249598 which results in accessing lastError after the statement is destroyed, instead of before.

As a sidenote I think https://bugs.webkit.org/show_bug.cgi?id=68465 was also fixed by the second of these changes, and can be closed.
Comment 1 Radar WebKit Bug Importer 2023-07-18 09:41:07 PDT 
<rdar://problem/112475480>
Comment 2 Ben Nham 2023-07-18 11:15:31 PDT 
*** Bug 259312 has been marked as a duplicate of this bug. ***
Comment 3 Ben Nham 2023-07-18 11:18:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15908
Comment 4 Ben Nham 2023-07-18 11:21:16 PDT 
Thanks for spotting this regression, we will try to apply the fix.
Comment 5 EWS 2023-07-18 14:28:15 PDT 
Committed 266139@main (a4485084ec04): <https://commits.webkit.org/266139@main>

Reviewed commits have been landed. Closing PR #15908 and removing active labels.