Bug 259310 - AX: VoiceOver only reading "link" for some lines when navigating via arrow up and down in contenteditables.
Summary: AX: VoiceOver only reading "link" for some lines when navigating via arrow up...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-18 10:15 PDT by Andres Gonzalez
Modified: 2023-07-18 14:23 PDT (History)
11 users (show)

See Also:

Attachments
Patch (17.53 KB, patch)
2023-07-18 10:33 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2023-07-18 10:15:51 PDT 
<div contenteditable id="editable">First line.<br>Some text <a href="#">click me</a> <span>more</span> text.<br><i>Another line.</i></div>
Comment 1 Radar WebKit Bug Importer 2023-07-18 10:16:10 PDT 
<rdar://problem/112478167>
Comment 2 Andres Gonzalez 2023-07-18 10:17:29 PDT 
rdar://112157851
Comment 3 Andres Gonzalez 2023-07-18 10:33:33 PDT 
Created attachment 467069 [details]
Patch
Comment 4 Tyler Wilcock 2023-07-18 10:44:05 PDT 
Comment on attachment 467069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467069&action=review

> Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:191
>      auto attributedText = propertyValue<RetainPtr<NSAttributedString>>(AXPropertyName::AttributedText);

Might be a micro-optimization not worth doing, but I don't think we need to attempt to retrieve AXPropertyName::AttributedText from the map if !isConfined.
Comment 5 EWS 2023-07-18 14:23:01 PDT 
Committed 266138@main (e9f264d34343): <https://commits.webkit.org/266138@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467069 [details].