Bug 259312 - Fix SQLiteDatabase::turnOnIncrementalAutoVacuum()
Summary: Fix SQLiteDatabase::turnOnIncrementalAutoVacuum()
Status: RESOLVED DUPLICATE of bug 259284
Alias: None
Product: WebKit
Classification: Unclassified
Component: Website Storage (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-18 11:14 PDT by Ben Nham
Modified: 2023-07-18 11:15 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2023-07-18 11:14:06 PDT 
PulkoMandy from the Haiku port found that turnOnIncrementalAutoVacuum is broken again on trunk due to 258673@main. (It was previously fixed in 241334@main.) The issue is that we need to call lastError() before finalizing the auto_vacuum statement rather than before. Otherwise lastError() returns the return code from the sqlite3_finalize that destroyed the statement rather than the sqlite3_step that enabled auto-vacuum.
Comment 1 Ben Nham 2023-07-18 11:15:31 PDT 

*** This bug has been marked as a duplicate of bug 259284 ***