Bug 259313 - Only special-case document element outermost <svg> embedded via a frame
Summary: Only special-case document element outermost <svg> embedded via a frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://wpt.live/svg/extensibility/for...
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-07-18 12:42 PDT by Ahmad Saleem
Modified: 2023-07-24 09:39 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-07-18 12:42:16 PDT
Hi Team,

This is just merge of Blink commit:

Commit: https://chromium-review.googlesource.com/c/chromium/src/+/4681730

It is to modify following:

https://github.com/WebKit/WebKit/blob/3dfb58beb2151d8039d5e56f6ddccddc9cd9d1ce/Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp#L127

Change:

if (!frame().ownerRenderer())

to

if (!frame().ownerRenderer() || !isDocumentElementRenderer())

______

Similar in LBSE to fix both in one go. It compiles and work.

_____

Just raising to fix it.

Thanks!
Comment 1 EWS 2023-07-24 09:37:09 PDT
Committed 266251@main (4d88a0a85b71): <https://commits.webkit.org/266251@main>

Reviewed commits have been landed. Closing PR #16012 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-07-24 09:39:44 PDT
<rdar://problem/112779569>