Bug 259352 - [macOS] WebKit should not re-export WebCore
Summary: [macOS] WebKit should not re-export WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks: 260114 264050
  Show dependency treegraph
 
Reported: 2023-07-19 17:53 PDT by Elliott Williams
Modified: 2023-11-01 14:42 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-07-19 17:53:46 PDT
We already have a mechanism for selectively exporting symbols from WebCore to clients, via WebKitLegacy's reexport lists. Hiding implementation details aside, avoiding a re-export means that generating WebKit's InstallAPI stub does not have to wait for WebCore to build, which is significant for build parallelism.
Comment 1 Elliott Williams 2023-07-19 17:56:49 PDT
<rdar://problem/110785133>
Comment 2 Elliott Williams 2023-07-21 12:51:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15997
Comment 3 EWS 2023-08-11 17:07:09 PDT
Committed 266838@main (e52304a6c26a): <https://commits.webkit.org/266838@main>

Reviewed commits have been landed. Closing PR #15997 and removing active labels.
Comment 4 Jonathan Bedard 2023-08-11 19:59:49 PDT
This broke the build, reverting and re-opening.
Comment 5 Elliott Williams 2023-08-17 14:57:01 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16807
Comment 6 EWS 2023-08-17 18:00:31 PDT
Committed 267022@main (07730ed3b3b9): <https://commits.webkit.org/267022@main>

Reviewed commits have been landed. Closing PR #16807 and removing active labels.
Comment 7 EWS 2023-08-18 13:14:46 PDT
Committed 267054@main (9ef92e6b63f9): <https://commits.webkit.org/267054@main>

Reviewed commits have been landed. Closing PR #16842 and removing active labels.