Bug 259519 - Make update-webkit-localizable-strings respect conditional inclusion
Summary: Make update-webkit-localizable-strings respect conditional inclusion
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-26 00:35 PDT by Anne van Kesteren
Modified: 2023-08-02 00:36 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2023-07-26 00:35:23 PDT 
As discovered in https://github.com/WebKit/WebKit/pull/16064 it ends up including strings in Localizable.strings from ports that don't use that file.
Comment 1 Anne van Kesteren 2023-07-26 06:23:30 PDT 
FWIW: excluding strings with "%s" or "%d" in them does not appear to be a workable approach.
Comment 2 Radar WebKit Bug Importer 2023-08-02 00:36:15 PDT 
<rdar://problem/113253656>