Bug 259527 - When using build-jsc on Linux: Can't exec "xcodebuild": No such file or directory
Summary: When using build-jsc on Linux: Can't exec "xcodebuild": No such file or direc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-26 11:45 PDT by Michael Catanzaro
Modified: 2023-07-28 08:43 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-07-26 11:45:47 PDT 
We have a (seemingly harmless) warning that prints when using build-jsc on Linux:

$ build-jsc --jsc-only --debug --cmakeargs='-DENABLE_C_LOOP=ON -DENABLE_JIT=OFF -DENABLE_SAMPLING_PROFILER=OFF'
Can't exec "xcodebuild": No such file or directory at /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitdirs.pm line 355.
Use of uninitialized value $xcodebuildVersionOutput in pattern match (m//) at /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitdirs.pm line 356.
Comment 1 Alexey Proskuryakov 2023-07-26 20:01:18 PDT 
A stack trace would help here - line 355 is in a function that shouldn't be called on Linux at all.
Comment 2 Michael Catanzaro 2023-07-27 08:39:19 PDT 
Stealing the solution to print a stack trace from https://stackoverflow.com/a/13088008/1120203, I found:

Stack Trace:
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitdirs.pm:1253 in function webkitdirs::xcodeVersion
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitperl/BuildSubproject.pm:150 in function webkitdirs::XcodeOptions
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/build-jsc:33 in function (eval)
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/build-jsc:33 in function main::BEGIN
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/build-jsc:33 in function (eval)

I think we can fix this by just moving the calling code into an XCode-specific path.
Comment 3 Michael Catanzaro 2023-07-27 08:40:51 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16139
Comment 4 EWS 2023-07-28 08:42:24 PDT 
Committed 266384@main (1c1ef14f21ca): <https://commits.webkit.org/266384@main>

Reviewed commits have been landed. Closing PR #16139 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2023-07-28 08:43:18 PDT 
<rdar://problem/113035669>