Bug 259550 - Convert <embed hidden> into a proper boolean attribute
Summary: Convert <embed hidden> into a proper boolean attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-07-27 04:20 PDT by Ahmad Saleem
Modified: 2023-07-28 14:06 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-07-27 04:20:57 PDT
Hi Team,

This is to fix test case:

WPT Live Link: http://wpt.live/html/semantics/embedded-content/the-embed-element/embed-hidden-attribute.html

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/3565492

________

Adding following in UA Stylesheet:

embed[hidden] { 
    display: inline; 
    height: 0; 
    width: 0;
} 

or fix by merging Blink Commit:

https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLEmbedElement.cpp#82

_____

UA Stylesheet fixes this above test case in WebKit but haven't run any test suite locally to confirm, if it regresses anything.

Thanks!
Comment 1 EWS 2023-07-28 14:05:14 PDT
Committed 266399@main (54238fd39a0d): <https://commits.webkit.org/266399@main>

Reviewed commits have been landed. Closing PR #16163 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-07-28 14:06:19 PDT
<rdar://problem/113051256>