Bug 259562 - REGRESSION(219104@main): Broke --analyze and --coverage flags of build-jsc/build-webgpu
Summary: REGRESSION(219104@main): Broke --analyze and --coverage flags of build-jsc/bu...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-27 08:37 PDT by Michael Catanzaro
Modified: 2023-08-03 08:38 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-07-27 08:37:55 PDT
It looks like 219104@main "build-jsc should invoke make instead of calling xcodebuild directly" broke the --analyze and --coverage options of build-jsc for Apple ports (and nowadays also build-webgpu since this code was moved from build-jsc to BuildSubproject.pm). (These options never worked for CMake ports.) When the flags are used, then additional XCode build options get added to @additionalSupportOptions, but this variable is no longer used anywhere. I don't know how to fix it.

Maybe the flags are not too valuable, since it took three years for us to notice, and I only noticed while trying to fix an unrelated bug (bug #259527). We should consider removing the flags. If we fix the flags instead of removing them, consider adjusting the help output to indicate they only work with XCode and not CMake.
Comment 1 Radar WebKit Bug Importer 2023-08-03 08:38:16 PDT
<rdar://problem/113337079>