Bug 259565 - [SOUP] Remove FIXME in NetworkProcess::allowsFirstPartyForCookies
Summary: [SOUP] Remove FIXME in NetworkProcess::allowsFirstPartyForCookies
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-27 08:57 PDT by Michael Catanzaro
Modified: 2023-07-27 08:57 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-07-27 08:57:55 PDT 
There is a FIXME at the top of NetworkProcess::allowsFirstPartyForCookies added in 266074@main:

if PLATFORM(GTK)
    // FIXME: This shouldn't be needed but is hit for some web socket tests on GTK.
    if (firstPartyDomain.isEmpty())
        return true;
#endif

We should figure out what's going wrong. The first party domain is not supposed to be empty.