Bug 259578 - Add TraceScope to capture layout-ey activities only
Summary: Add TraceScope to capture layout-ey activities only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-27 14:21 PDT by zalan
Modified: 2023-07-27 17:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2023-07-27 14:22 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.39 KB, patch)
2023-07-27 15:10 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.76 KB, patch)
2023-07-27 15:49 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2023-07-27 15:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-07-27 14:21:16 PDT 
ssia
Comment 1 zalan 2023-07-27 14:22:39 PDT 
Created attachment 467137 [details]
Patch
Comment 2 Simon Fraser (smfr) 2023-07-27 14:32:18 PDT 
Comment on attachment 467137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467137&action=review

> Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246
> +        TraceScope tracingScope(LayoutStart, LayoutEnd);

This no longer includes InViewSizeAdjust or InPostLayout, which don't have their own trace point coverage. This will make it harder to see how much tine they are taking for forced layouts.
Comment 3 zalan 2023-07-27 14:33:53 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 467137 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467137&action=review
> 
> > Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246
> > +        TraceScope tracingScope(LayoutStart, LayoutEnd);
> 
> This no longer includes InViewSizeAdjust or InPostLayout, which don't have
> their own trace point coverage. This will make it harder to see how much
> tine they are taking for forced layouts.

sure but they are not layout either. do you want me to add new trace scopes?
Comment 4 zalan 2023-07-27 14:36:08 PDT 
(In reply to zalan from comment #3)
> (In reply to Simon Fraser (smfr) from comment #2)
> > Comment on attachment 467137 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=467137&action=review
> > 
> > > Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246
> > > +        TraceScope tracingScope(LayoutStart, LayoutEnd);
> > 
> > This no longer includes InViewSizeAdjust or InPostLayout, which don't have
> > their own trace point coverage. This will make it harder to see how much
> > tine they are taking for forced layouts.
> 
> sure but they are not layout either. do you want me to add new trace scopes?
also don't we just re-enter LocalFrameViewLayoutContext::performLayout?
Comment 5 zalan 2023-07-27 15:10:50 PDT 
Created attachment 467138 [details]
Patch
Comment 6 zalan 2023-07-27 15:49:11 PDT 
Created attachment 467139 [details]
Patch
Comment 7 zalan 2023-07-27 15:50:36 PDT 
Created attachment 467140 [details]
Patch
Comment 8 EWS 2023-07-27 17:56:25 PDT 
Committed 266372@main (703501c4541f): <https://commits.webkit.org/266372@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467140 [details].
Comment 9 Radar WebKit Bug Importer 2023-07-27 17:57:19 PDT 
<rdar://problem/113006480>