Bug 259639 - [Win][MiniBrowser] A download dialog is displayed even though the content is not for download since 266320@main
Summary: [Win][MiniBrowser] A download dialog is displayed even though the content is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-30 18:48 PDT by Kenji Shukuwa
Modified: 2023-08-01 05:14 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Kenji Shukuwa 2023-07-30 18:52:03 PDT 
The content that displayed the download dialog did not have a Content-Type header.
Therefore the MIME type is empty.
Comment 2 Kenji Shukuwa 2023-07-30 18:58:17 PDT 
The SOUP port does not seem to download subframe content.


https://github.com/WebKit/WebKit/blob/e50b54c0585e5846b51d94711b75515282bc3bd8/Tools/MiniBrowser/gtk/BrowserTab.c#L129-L130
---
    if (!webkit_response_policy_decision_is_main_frame_main_resource(responseDecision))
        return FALSE;
---
Comment 3 Kenji Shukuwa 2023-07-30 19:45:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16223
Comment 4 EWS 2023-08-01 05:13:15 PDT 
Committed 266471@main (b6570992dff1): <https://commits.webkit.org/266471@main>

Reviewed commits have been landed. Closing PR #16223 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2023-08-01 05:14:20 PDT 
<rdar://problem/113200343>