Bug 259669 - [run-benchmarks] Use `ktrace artrace` for profiling browser benchmarks
Summary: [run-benchmarks] Use `ktrace artrace` for profiling browser benchmarks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: hysu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-31 16:16 PDT by hysu
Modified: 2023-08-01 14:26 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2023-07-31 16:16:23 PDT 
https://bugs.webkit.org/show_bug.cgi?id=247496 implemented the `--profile` argument into run-benchmarks, but until now this hasn't done anything.

On macOS, we should use `ktrace artrace`, and allow the user to specify a trace type (either `full` or `profile`).
Comment 1 Radar WebKit Bug Importer 2023-07-31 16:17:11 PDT 
<rdar://problem/113167762>
Comment 2 hysu 2023-07-31 16:26:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16252
Comment 3 EWS 2023-08-01 14:26:18 PDT 
Committed 266492@main (4b03459ba7f6): <https://commits.webkit.org/266492@main>

Reviewed commits have been landed. Closing PR #16252 and removing active labels.