Bug 259715 - Merge ResourceLoadStatisticsStore and ResourceLoadStatisticsDatabaseStore
Summary: Merge ResourceLoadStatisticsStore and ResourceLoadStatisticsDatabaseStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-01 16:50 PDT by Brent Fulgham
Modified: 2023-08-09 15:13 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-08-01 16:50:28 PDT
Now that we only have a SQLite-based ITP database, we should remove the needless layering created by a separate ResourceLoadStatisticsStore and ResourceLoadStatisticsDatabaseStore child class.

This will allow us to reduce complexity by removing a needless child class, but will also remove numerous virtual method calls, type checks, and downcast operations needed to dispatch methods to the child class.
Comment 1 Radar WebKit Bug Importer 2023-08-01 16:50:48 PDT
<rdar://problem/113236158>
Comment 2 Brent Fulgham 2023-08-01 17:10:40 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16298
Comment 3 EWS 2023-08-09 15:13:11 PDT
Committed 266741@main (f0bb8782e85b): <https://commits.webkit.org/266741@main>

Reviewed commits have been landed. Closing PR #16298 and removing active labels.