WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
259753
[git-webkit] setup ends up hardcoding worktree path in hooks
https://bugs.webkit.org/show_bug.cgi?id=259753
Summary
[git-webkit] setup ends up hardcoding worktree path in hooks
Sam Sneddon [:gsnedders]
Reported
2023-08-02 15:26:32 PDT
`git-webkit setup` ends up inserting a line such as: ``` LOCATION = r'/Volumes/gsnedders/projects/Safari/OS2/Tools/Scripts/hooks/prepare-commit-msg' ``` However, in my case, this has ended up with a path within a worktree hardcoded in the hook. This… stopped working when I pruned the worktree. We should, at most, hardcode the path from the top-level directory of the working tree, and then just use the current working tree.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-08-02 15:26:44 PDT
<
rdar://problem/113294324
>
Sam Sneddon [:gsnedders]
Comment 2
2023-08-02 15:52:31 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/16332
EWS
Comment 3
2023-08-04 03:45:10 PDT
Committed
266577@main
(3aa38b6cb9f2): <
https://commits.webkit.org/266577@main
> Reviewed commits have been landed. Closing PR #16332 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug