Bug 259799 - PaymentSetupConfiguration.mm is duplicated under WebKit/Shared/ApplePay/
Summary: PaymentSetupConfiguration.mm is duplicated under WebKit/Shared/ApplePay/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Abrar Rahman Protyasha
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-03 15:10 PDT by Abrar Rahman Protyasha
Modified: 2023-08-03 21:10 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2023-08-03 15:10:33 PDT 
During upstreaming of Apple Pay code from WKA, we seem to have duplicated the source file for PaymentSetupConfiguration in both WebKit/Shared/ApplePay/PaymentSetupConfiguration.mm and WebKit/Shared/ApplePay/cocoa/PaymentSetupConfiguration.mm, with the latter source file existing silently in the repository without any use.

We should clean this up by removing one of the source files.
Comment 1 Radar WebKit Bug Importer 2023-08-03 15:10:45 PDT 
<rdar://problem/113360189>
Comment 2 Abrar Rahman Protyasha 2023-08-03 15:26:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16367
Comment 3 EWS 2023-08-03 21:10:49 PDT 
Committed 266568@main (a069e94f1dc5): <https://commits.webkit.org/266568@main>

Reviewed commits have been landed. Closing PR #16367 and removing active labels.