WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
259835
Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server
https://bugs.webkit.org/show_bug.cgi?id=259835
Summary
Investigate the possibility of replacing twisted http server in run-benchmark...
dewei_zhu
Reported
2023-08-04 12:51:09 PDT
Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server. Moving to python3 http.server would have following benefits: 1. Remove the dependency of Twisted, which could be an issue for some users local environment. 2. Speedup the first run for run-benchmark, which installs twisted if no local installation The reason the initial version does not use python2 built-in http server is because sometimes the http server fails to server the content. We should ensure python3 version does not have this issue. Furthermore, we also need to make sure the benchmark score does not change by switching between different http servers. Base on above, it seems reasonable to implement http.server version separately and use a flag to switch to http.server.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-08-11 12:52:12 PDT
<
rdar://problem/113766369
>
james
Comment 2
2023-08-21 14:11:26 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/16900
EWS
Comment 3
2023-11-27 15:46:28 PST
Committed
271176@main
(1e3555d85962): <
https://commits.webkit.org/271176@main
> Reviewed commits have been landed. Closing PR #16900 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug