Bug 259856 - [css-nesting] CSSStyleRule should inherit from CSSGroupingRule
Summary: [css-nesting] CSSStyleRule should inherit from CSSGroupingRule
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-08-04 22:29 PDT by Tim Nguyen (:ntim)
Modified: 2023-12-21 05:01 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Matthieu Dubet 2023-08-05 01:19:08 PDT 
Fun fact, I had anticipated this change in the spec back in March but never got it merged https://github.com/WebKit/WebKit/pull/11835
Comment 3 Radar WebKit Bug Importer 2023-08-11 22:30:13 PDT 
<rdar://problem/113787558>
Comment 4 Tim Nguyen (:ntim) 2023-08-12 02:25:49 PDT 
(In reply to Matthieu Dubet from comment #2)
> https://github.com/WebKit/WebKit/pull/9332/files#diff-
> 42726ca1f6c0499ccb16f1be2a209fc147a4f01139c7de9b9ad51aab94ea8231R37

Now that it matches the IDL, it's probably more acceptable.
Comment 5 Ahmad Saleem 2023-09-20 11:51:36 PDT 
I think we still missing one change and failing following sub-test here:

WPT Test: http://wpt.live/css/css-nesting/cssom.html

___

CSSStyleRule is a CSSGroupingRule	

We get:

assert_equals: expected function "function CSSGroupingRule() { [native code] }" but got function "function CSSRule() { [native code] }"
@http://wpt.live/css/css-nesting/cssom.html:12:18
@http://wpt.live/resources/testharness.js:2599:30
test@http://wpt.live/resources/testharness.js:628:34
global code@http://wpt.live/css/css-nesting/cssom.html:11:7

___

Or we should close this and have separate?
Comment 6 Matthieu Dubet 2023-12-21 01:20:07 PST 
No indeed, this has never been merged so still need to be fixed (changing the IDL is easy, but it need a refactoring of the StyleRuleBase/StyleRuleGroup/StyleRuleWithNesting classes)