Bug 259857 - makeOpportunisticTaskDeferralScopeIfPossible has a wrong early exit logic
Summary: makeOpportunisticTaskDeferralScopeIfPossible has a wrong early exit logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 259876
Blocks: 203137
  Show dependency tree / graph
 
Reported: 2023-08-04 23:41 PDT by Ryosuke Niwa
Modified: 2023-08-08 01:07 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2023-08-04 23:41:47 PDT 
makeOpportunisticTaskDeferralScopeIfPossible exits early whenever m_currentTimerInterval <= 1ms.
But we should be exiting early whenever m_currentTimerInterval > 1ms instead.
Comment 1 Ryosuke Niwa 2023-08-04 23:45:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16420
Comment 2 Radar WebKit Bug Importer 2023-08-05 17:03:39 PDT 
<rdar://problem/113450386>
Comment 3 EWS 2023-08-05 20:38:14 PDT 
Committed 266621@main (38e5de251688): <https://commits.webkit.org/266621@main>

Reviewed commits have been landed. Closing PR #16420 and removing active labels.
Comment 4 WebKit Commit Bot 2023-08-06 14:12:13 PDT 
Re-opened since this is blocked by bug 259876
Comment 5 Ryosuke Niwa 2023-08-07 21:00:29 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16464
Comment 6 EWS 2023-08-08 01:07:44 PDT 
Committed 266680@main (e9d28ce63fa4): <https://commits.webkit.org/266680@main>

Reviewed commits have been landed. Closing PR #16464 and removing active labels.