Bug 259900 - [IFC] Add fast path for simple text only content
Summary: [IFC] Add fast path for simple text only content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-07 14:37 PDT by zalan
Modified: 2023-08-11 07:07 PDT (History)
10 users (show)

See Also:

Attachments
Patch (83.31 KB, patch)
2023-08-07 16:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (83.04 KB, patch)
2023-08-07 19:34 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (82.96 KB, patch)
2023-08-07 20:00 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (88.64 KB, patch)
2023-08-08 11:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (87.55 KB, patch)
2023-08-08 17:17 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (87.40 KB, patch)
2023-08-10 09:17 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (87.59 KB, patch)
2023-08-11 05:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (87.44 KB, patch)
2023-08-11 06:02 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-08-07 14:37:54 PDT 
ssia
Comment 1 zalan 2023-08-07 16:37:58 PDT 
Created attachment 467215 [details]
Patch
Comment 2 zalan 2023-08-07 19:34:41 PDT 
Created attachment 467216 [details]
Patch
Comment 3 zalan 2023-08-07 20:00:47 PDT 
Created attachment 467217 [details]
Patch
Comment 4 zalan 2023-08-08 11:21:31 PDT 
Created attachment 467223 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2023-08-08 14:20:09 PDT 
<rdar://problem/113585987>
Comment 6 zalan 2023-08-08 17:17:17 PDT 
Created attachment 467226 [details]
Patch
Comment 7 Antti Koivisto 2023-08-10 08:10:23 PDT 
Comment on attachment 467226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467226&action=review

Very cool. SLL is back!

> Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.h:101
> +class AbstractLineBuilder {
> +public:
> +    virtual LineLayoutResult layoutInlineContent(const LineInput&, const std::optional<PreviousLine>&) = 0;
> +    virtual ~AbstractLineBuilder() { };
> +};

Maybe we could use a template instead of this at some point.
Comment 8 zalan 2023-08-10 09:17:35 PDT 
Created attachment 467237 [details]
Patch
Comment 9 zalan 2023-08-11 05:56:52 PDT 
Created attachment 467244 [details]
Patch
Comment 10 zalan 2023-08-11 06:02:31 PDT 
Created attachment 467245 [details]
Patch
Comment 11 EWS 2023-08-11 07:07:37 PDT 
Committed 266815@main (ba2673dfb458): <https://commits.webkit.org/266815@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467245 [details].