Bug 259937 - [IFC] Enable the ability to override available width for line boxes
Summary: [IFC] Enable the ability to override available width for line boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Choi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-08 11:13 PDT by David Choi
Modified: 2023-08-15 12:08 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Choi 2023-08-08 11:13:57 PDT
The available width for a line box is originally determined by the HorizontalConstraints struct. However, it is sometimes desirable to override that width constraint. One potential reason to override that width constraint is to force line breaks at particular inline items. (Currently, there is no way to specify to the LineBuilder to break at certain InlineItems, and the only way to do so is to modify the available space on the line.) This is useful for CSS properties such as text-wrap, which need to make line-breaking decisions that do not follow the current greedy approach of filling up the entire available width.
Comment 1 Radar WebKit Bug Importer 2023-08-08 11:15:00 PDT
<rdar://problem/113575336>
Comment 2 David Choi 2023-08-08 11:23:49 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16481
Comment 3 David Choi 2023-08-08 11:32:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16482
Comment 4 EWS 2023-08-15 12:08:27 PDT
Committed 266921@main (b603ea06b45a): <https://commits.webkit.org/266921@main>

Reviewed commits have been landed. Closing PR #16482 and removing active labels.