Bug 259982 - [CMake] Add option to control assertions
Summary: [CMake] Add option to control assertions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick Griffis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-09 10:54 PDT by Patrick Griffis
Modified: 2023-08-10 13:46 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Griffis 2023-08-09 10:54:20 PDT 
The macOS port already allows building `release+assert` but the cmake project didn't expose this.
    
This adds a `-DENABLE_ASSERTS` option to enable with a normal release build.
Comment 1 Patrick Griffis 2023-08-09 10:57:00 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16526
Comment 2 EWS 2023-08-10 13:46:33 PDT 
Committed 266778@main (1ef24965e556): <https://commits.webkit.org/266778@main>

Reviewed commits have been landed. Closing PR #16526 and removing active labels.