Bug 260053 - Force consumers of Connection::waitForAndDispatchImmediately to declare usage in the messages.in file
Summary: Force consumers of Connection::waitForAndDispatchImmediately to declare usage...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-10 19:15 PDT by Matt Woodrow
Modified: 2023-08-22 20:26 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-08-10 19:15:02 PDT 
waitForAndDispatchImmediately causes the waited on message to be delivered synchronous, and breaks expectations about IPC messages being delivered in order.

Usage of waitForAndDispatchImmediately can be subtle (if not explicitly searched for), so it's easy to add new IPC messages that expect in-order delivery.
Comment 1 Matt Woodrow 2023-08-10 19:17:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16590
Comment 2 Radar WebKit Bug Importer 2023-08-17 19:15:13 PDT 
<rdar://problem/114059668>
Comment 3 EWS 2023-08-22 20:26:23 PDT 
Committed 267178@main (2c3c1f0afc15): <https://commits.webkit.org/267178@main>

Reviewed commits have been landed. Closing PR #16590 and removing active labels.