Bug 260104 - AX: Test style cleanup for aria-current.html
Summary: AX: Test style cleanup for aria-current.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-11 15:45 PDT by Joshua Hoffman
Modified: 2023-08-15 09:18 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2023-08-11 15:51 PDT, Joshua Hoffman 		no flags Details | Formatted Diff | Diff
Patch (3.64 KB, patch)
2023-08-14 15:09 PDT, Joshua Hoffman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Hoffman 2023-08-11 15:45:54 PDT 
Adjust the test style of aria-current to be more consistent with other AX tests.
Comment 1 Radar WebKit Bug Importer 2023-08-11 15:46:05 PDT 
<rdar://problem/113775205>
Comment 2 Joshua Hoffman 2023-08-11 15:51:03 PDT 
Created attachment 467249 [details]
Patch
Comment 3 Andres Gonzalez 2023-08-14 06:44:22 PDT 
(In reply to Joshua Hoffman from comment #2)
> Created attachment 467249 [details]
> Patch

Thanks Josh. One more style guideline and we are there. Use JS templete strings instead of concatenation, e.g.:

-    output += "PASS: AXARIACurrent is " + value + "\n";

+    output += `PASS: AXARIACurrent is ${value}\n`;
Comment 4 Joshua Hoffman 2023-08-14 15:09:53 PDT 
Created attachment 467273 [details]
Patch
Comment 5 EWS 2023-08-15 09:18:19 PDT 
Committed 266913@main (bb3bc0cc2777): <https://commits.webkit.org/266913@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467273 [details].