Bug 260126 - [IntersectionObserver] Fix some edge cases in parsing options
Summary: [IntersectionObserver] Fix some edge cases in parsing options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://wpt.live/intersection-observer...
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-08-13 09:24 PDT by Ahmad Saleem
Modified: 2023-08-13 13:38 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-08-13 09:24:11 PDT 
Hi Team,

This is just another Blink merge to fix IntersectionObserver bugs.

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/2388706

WPT Live Link: http://wpt.live/intersection-observer/observer-attributes.html

WPT Test Case: https://wpt.fyi/results/intersection-observer/observer-attributes.html?label=master&label=experimental&aligned=

____

WebKit Source Changes:

First Line 159 >  tokenRange.consumeWhitespace();

Second Line 121 below:

if (thresholds.isEmpty())
        thresholds.append(0.f);

______

We are after above changes passing all tests.

Thanks!
Comment 1 EWS 2023-08-13 13:37:01 PDT 
Committed 266856@main (0fcecf40e3a1): <https://commits.webkit.org/266856@main>

Reviewed commits have been landed. Closing PR #16648 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-08-13 13:38:11 PDT 
<rdar://problem/113826514>