Bug 260136 - [web-animations] linear() probably does not work with transform and other accelerated properties
Summary: [web-animations] linear() probably does not work with transform and other acc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-14 03:47 PDT by Antoine Quint
Modified: 2023-10-20 14:39 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-08-14 03:47:17 PDT
I expect the changes made in 266196@main for bug 240061 are not dealing with accelerated animations. Indeed, CoreAnimation doesn’t have any native equivalent to linear() so we’ll have to either find something that matches and add code to translate to the CA-native primitive or expand KeyframeEffect::canBeAccelerated() to do something similar to what we do with steps(). I argue for the latter because with the work for threaded animation resolution support for linear() will be free and I think it’s not a good idea to add more CA-specific code.
Comment 1 Radar WebKit Bug Importer 2023-08-21 03:48:14 PDT
<rdar://problem/114185868>
Comment 2 Antoine Quint 2023-10-20 06:56:54 PDT
<rdar://114084978>
Comment 3 Antoine Quint 2023-10-20 07:17:01 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19341
Comment 4 EWS 2023-10-20 14:39:01 PDT
Committed 269594@main (07b0116f3ef9): <https://commits.webkit.org/269594@main>

Reviewed commits have been landed. Closing PR #19341 and removing active labels.