Bug 260186 - REGRESSION(266244@main): Build failure with libjxl < 0.7.0
Summary: REGRESSION(266244@main): Build failure with libjxl < 0.7.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-14 17:31 PDT by Carlos Alberto Lopez Perez
Modified: 2023-08-15 04:53 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2023-08-14 17:31:48 PDT 
The macros JPEGXL_NUMERIC_VERSION and JPEGXL_COMPUTE_NUMERIC_VERSION where introduced in libjxl 0.7.0

Versions lower than that (like 0.6.0) don't define this macros.

This causes the following build error since 266244@main

/home/buildbot/worker/WPE-Linux-RPi4-32bits-Mesa-Release-Perf-Build/build/Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp:430:60: error: missing binary operator before token "("
/home/buildbot/worker/WPE-Linux-RPi4-32bits-Mesa-Release-Perf-Build/build/Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp:438:54: error: cannot convert ‘JxlColorProfileTarget’ to ‘const JxlPixelFormat*’
/home/buildbot/worker/WPE-Linux-RPi4-32bits-Mesa-Release-Perf-Build/build/Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp:442:57: error: cannot convert ‘JxlColorProfileTarget’ to ‘const JxlPixelFormat*’

https://build.webkit.org/#/builders/893/builds/1104
Comment 1 Carlos Alberto Lopez Perez 2023-08-14 17:37:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16692
Comment 2 EWS 2023-08-15 04:53:54 PDT 
Committed 266903@main (5caa0800061a): <https://commits.webkit.org/266903@main>

Reviewed commits have been landed. Closing PR #16692 and removing active labels.