Bug 260256 - [WPE][GTK] API test `TestWebsiteData` `/webkit/WebKitWebsiteData/memory-pressure` is a timeout
Summary: [WPE][GTK] API test `TestWebsiteData` `/webkit/WebKitWebsiteData/memory-press...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 260262
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-16 05:31 PDT by Vitaly Dyackhov
Modified: 2023-08-17 08:11 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Dyackhov 2023-08-16 05:31:53 PDT
This test verifies that the network process will be killed if the memory limit is reached.
It's done by calling `webkit_network_session_set_memory_pressure_settings()`.
The settings passed as an argument are later applied during the creation of a new network process.

Before 259433@main a new network process was created for every network session but now only one network process is created.
Since this test is not the first one in the test suite, the network process was already created and the memory pressure settings have no effect.

Also, the name of the function is misleading now, because the memory pressure settings are applied to all sessions.
Comment 1 Vitaly Dyackhov 2023-08-16 06:10:05 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16742
Comment 2 EWS 2023-08-16 08:21:39 PDT
Committed 266946@main (53084658b468): <https://commits.webkit.org/266946@main>

Reviewed commits have been landed. Closing PR #16742 and removing active labels.
Comment 3 WebKit Commit Bot 2023-08-16 08:55:43 PDT
Re-opened since this is blocked by bug 260262
Comment 4 Vitaly Dyackhov 2023-08-17 04:25:23 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16785
Comment 5 EWS 2023-08-17 08:11:29 PDT
Committed 267000@main (c49fe081e573): <https://commits.webkit.org/267000@main>

Reviewed commits have been landed. Closing PR #16785 and removing active labels.