Bug 260257 - [IFC] TextOnlyLineBuilder should handle content with 'white-space: break-spaces'
Summary: [IFC] TextOnlyLineBuilder should handle content with 'white-space: break-spaces'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-16 07:15 PDT by zalan
Modified: 2023-08-16 12:50 PDT (History)
5 users (show)

See Also:

Attachments
[fast-cq]Patch (7.95 KB, patch)
2023-08-16 07:29 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-08-16 07:15:20 PDT 
ssia
Comment 1 zalan 2023-08-16 07:29:12 PDT 
Created attachment 467290 [details]
[fast-cq]Patch
Comment 2 Antti Koivisto 2023-08-16 12:01:16 PDT 
Comment on attachment 467290 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467290&action=review

> Source/WebCore/layout/formattingContexts/inline/TextOnlyLineBuilder.cpp:148
> +    size_t placedInlineItemCount = 0;

C++23 will have uz literal for this!
Comment 3 zalan 2023-08-16 12:45:47 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 467290 [details]
> [fast-cq]Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467290&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/TextOnlyLineBuilder.cpp:148
> > +    size_t placedInlineItemCount = 0;
> 
> C++23 will have uz literal for this!
autos will finally be nicely lined up.
Comment 4 EWS 2023-08-16 12:49:36 PDT 
Committed 266955@main (3467db480187): <https://commits.webkit.org/266955@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467290 [details].
Comment 5 Radar WebKit Bug Importer 2023-08-16 12:50:35 PDT 
<rdar://problem/113983232>