Bug 260390 - Don't allow form-feed (U+000C) as a WebVTT signature separator
Summary: Don't allow form-feed (U+000C) as a WebVTT signature separator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anne van Kesteren
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on: 179370
Blocks:
  Show dependency tree / graph
 
Reported: 2023-08-18 09:42 PDT by Ahmad Saleem
Modified: 2023-10-20 23:05 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-08-18 09:42:17 PDT 
Hi Team,

This is another Blink merge to get another WPT win.

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/84007ecf0f27d2074c70955d43cc1743ee39980a

WPT Test Case Live Link: http://wpt.live/webvtt/parsing/file-parsing/signature-invalid.html

^ We fail two but this bug is about 'signature - formfeed'.

I have local patch for it to progress the above.

Web-Spec: https://w3c.github.io/webvtt/#webvtt-parser-algorithm

Just wanted to raise so we can fix it.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-08-18 18:36:03 PDT 
<rdar://problem/114118340>
Comment 2 Karl Dubost 2023-08-20 18:21:22 PDT 
Ahmad,
That seems like a low hanging fruit.
Comment 3 Anne van Kesteren 2023-09-07 22:29:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17576
Comment 4 EWS 2023-10-20 23:05:51 PDT 
Committed 269619@main (f98a7bee4cc3): <https://commits.webkit.org/269619@main>

Reviewed commits have been landed. Closing PR #17576 and removing active labels.