Bug 260392 - Apply paint containment via 'mediaControl.css' control stylesheet
Summary: Apply paint containment via 'mediaControl.css' control stylesheet
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-08-18 09:45 PDT by Ahmad Saleem
Modified: 2024-03-10 05:58 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-08-18 09:45:25 PDT
Hi Team,

This is another Blink merge:

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/4349736

WPT Test Case Live Link: http://wpt.live/webvtt/rendering/cues-with-video/processing-model/evil/non-standard-pseudo-elements.html

Just wanted to raise so we can fix it.

Adding 'BrowserCompat' since only Safari is failing the test case.

If there is alternative way to fix this, happy to take inputs and someone can take it up as well.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-08-25 09:46:19 PDT
<rdar://problem/114456301>
Comment 2 Ahmad Saleem 2024-03-10 05:58:10 PDT
These were additionals:

audio::-webkit-media-controls,
video::-webkit-media-controls {
    contain: paint !important;
}
video::-webkit-media-text-track-container {
    contain: paint !important;
    position: relative !important;
}

______

Here - https://searchfox.org/wubkat/rev/93c3eb8ac99a6b6e3894deaf14e5d38304898b48/Source/WebCore/css/mediaControls.css#30

I think we have to add:

contain: paint !important;

and good to change it to make exclusive to `audio` and `video`.

and for `-webkit-media-text-track-container`, we have it in `mediaControls.css` and `text-tracks.css` and both of them have multiple duplicate rules, which is bug 268269.