Bug 260401 - Many methods in ComputedStyleExtractor can be const
Summary: Many methods in ComputedStyleExtractor can be const
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks: 260397
  Show dependency tree / graph
 
Reported: 2023-08-18 11:17 PDT by Sammy Gill
Modified: 2023-08-18 13:43 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-08-18 11:17:59 PDT 
Many methods here compute a value and return it without modifying any sort of state in the class. In these cases we can make them const so that they can be used whenever other code uses a const ComputedStyleExtractor
Comment 1 Radar WebKit Bug Importer 2023-08-18 11:19:55 PDT 
<rdar://problem/114099664>
Comment 2 Sammy Gill 2023-08-18 11:26:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16841
Comment 3 EWS 2023-08-18 13:43:18 PDT 
Committed 267055@main (f5c4eacf1b68): <https://commits.webkit.org/267055@main>

Reviewed commits have been landed. Closing PR #16841 and removing active labels.