Bug 260434 - Make it possible to put fuzzy pixel matching thresholds in TestExpectations
Summary: Make it possible to put fuzzy pixel matching thresholds in TestExpectations
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-19 11:51 PDT by Matthieu Dubet
Modified: 2024-03-20 12:51 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Dubet 2023-08-19 11:51:42 PDT
We should have a new kind of test expectations to precisely defined how many pixels difference we have with the reference, to avoid any regression/show improvement.
Comment 1 Radar WebKit Bug Importer 2023-08-19 11:51:57 PDT
<rdar://problem/114138795>
Comment 2 Alexey Proskuryakov 2023-08-21 08:27:09 PDT
An older proposal was to add a mask image that precisely defines which pixels can be different. It's more complicated to implement of course, especially as we'd need tooling to create such masks.
Comment 3 Simon Fraser (smfr) 2023-08-21 09:54:44 PDT
Fuzzy matching can specify a range of pixels (but not which ones).
Comment 4 Simon Fraser (smfr) 2023-08-21 09:55:22 PDT
Oh, I think the request here is to put the fuzzy matching data in TestExpectations, rather than in the test.

Matthieu, could you clarify what you're asking for?
Comment 5 Matthieu Dubet 2024-03-20 11:00:32 PDT
@Simon,

Yes this is about our expectations/our current state, so it should be in the TestExpectations (like the textual expectations with a bunch of PASS and FAIL)

It's not about fuzzing per se (but it could reuse the fuzzing infrastructure to determine the pixel differences).