Bug 260454 - [IFC] Add non-line-builder based minimum width computation
Summary: [IFC] Add non-line-builder based minimum width computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-20 19:24 PDT by zalan
Modified: 2023-08-21 19:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.29 KB, patch)
2023-08-20 19:30 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.29 KB, patch)
2023-08-21 11:00 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[fast-cq]Patch (9.64 KB, patch)
2023-08-21 14:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-08-20 19:24:25 PDT 
ssia
Comment 1 zalan 2023-08-20 19:30:43 PDT 
Created attachment 467352 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2023-08-20 19:30:57 PDT 
<rdar://problem/114170752>
Comment 3 Antti Koivisto 2023-08-21 08:50:18 PDT 
Comment on attachment 467352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467352&action=review

> COMMIT_MESSAGE:8
> +(This is a 4x speedup on PerformanceTests/Layout/line-layout-preferred-width-break-all.html)

Not even 10x. Sad.

> Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:39
> +static bool isEligibleForNonLineBuilderProcess(const RenderStyle& style)

A new process?
Comment 4 zalan 2023-08-21 11:00:45 PDT 
Created attachment 467371 [details]
Patch
Comment 5 zalan 2023-08-21 14:14:24 PDT 
Created attachment 467372 [details]
[fast-cq]Patch
Comment 6 EWS 2023-08-21 19:56:55 PDT 
Committed 267116@main (23014ddf9929): <https://commits.webkit.org/267116@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467372 [details].