Bug 260485 - [JSC] Generator functions should not be Annex B hoisting candidates
Summary: [JSC] Generator functions should not be Annex B hoisting candidates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P1 Major
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks: 260484
  Show dependency tree / graph
 
Reported: 2023-08-21 13:23 PDT by Alexey Shvayka
Modified: 2023-09-22 19:38 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2023-08-21 13:23:56 PDT 
Related test262 failures:
  * test/language/statements/switch/scope-lex-async-function.js
  * test/language/statements/switch/scope-lex-async-generator.js
  * test/language/statements/switch/scope-lex-generator.js

Fix: add template parameter to `std::pair<DeclarationResultMask, ScopeRef> declareFunction(const Identifier*)` of Parser.h to avoid hoisting function unconditionally.
Comment 1 Radar WebKit Bug Importer 2023-08-21 13:24:44 PDT Comment hidden (obsolete)
Comment 2 Radar WebKit Bug Importer 2023-08-21 13:25:42 PDT 
<rdar://problem/114213642>
Comment 3 Alexey Shvayka 2023-09-22 15:49:00 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18108
Comment 4 EWS 2023-09-22 19:38:00 PDT 
Committed 268352@main (b215cab40b67): <https://commits.webkit.org/268352@main>

Reviewed commits have been landed. Closing PR #18108 and removing active labels.