Bug 260494 - grid-template not serialized correctly if grid-template-areas was not set from shorthand
Summary: grid-template not serialized correctly if grid-template-areas was not set fro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks: 204611
  Show dependency tree / graph
 
Reported: 2023-08-21 16:28 PDT by Sammy Gill
Modified: 2023-08-22 16:01 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-08-21 16:28:51 PDT 
ShorthandSerializer::serializeGridTemplate bails out early if it has to serialize the third version of the shorthand ([ <line-names>? <string> <track-size>? <line-names>? ]+ [ / <explicit-track-list> ]?) and the values were not set from the shorthand. We should be checking these values directly and see if they can be represented in this syntax
Comment 1 Radar WebKit Bug Importer 2023-08-21 16:29:19 PDT 
<rdar://problem/114224504>
Comment 2 Sammy Gill 2023-08-21 17:13:49 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16909
Comment 3 Sammy Gill 2023-08-22 15:17:15 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/41592
Comment 4 EWS 2023-08-22 16:01:33 PDT 
Committed 267155@main (74849b01b119): <https://commits.webkit.org/267155@main>

Reviewed commits have been landed. Closing PR #16909 and removing active labels.