Bug 260531 - [css-grid] css-grid/subgrid/subgrid-no-items-on-edges-001.html failing
Summary: [css-grid] css-grid/subgrid/subgrid-no-items-on-edges-001.html failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks: 260533
  Show dependency tree / graph
 
Reported: 2023-08-22 11:16 PDT by Sammy Gill
Modified: 2023-10-05 16:18 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-08-22 11:16:44 PDT 
css-grid/subgrid/subgrid-no-items-on-edges-001.html is currently failing on WPT
Comment 1 Radar WebKit Bug Importer 2023-08-22 11:16:58 PDT 
<rdar://problem/114271839>
Comment 2 Sammy Gill 2023-09-05 14:15:47 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17456
Comment 3 Sammy Gill 2023-09-19 17:11:52 PDT 
This patch is not quite ready yet. I think there is a simpler way of going about this so I'm going to attempt a new approach that will be much less convoluted. 

The basis idea will be that we already recurse into a nested subgrid with the additional call to accumulateIntrinsicSizesForTrack so we can perhaps just store some extra information as new arguments that the nested margin, border, and padding will accumulate into
Comment 4 EWS 2023-10-05 16:18:57 PDT 
Committed 268947@main (ebd030f9b866): <https://commits.webkit.org/268947@main>

Reviewed commits have been landed. Closing PR #17456 and removing active labels.