Bug 260541 - REGRESSION(267124@main): [Win] layout tests using a context menu are timing out
Summary: REGRESSION(267124@main): [Win] layout tests using a context menu are timing out
Status: RESOLVED DUPLICATE of bug 260821
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-22 14:10 PDT by Fujii Hironori
Modified: 2023-08-29 14:35 PDT (History)
1 user (show)

See Also:

Attachments
WIP patch (2.70 KB, patch)
2023-08-23 17:28 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2023-08-22 14:10:08 PDT 
REGRESSION(267124@main): [Win] layout tests using a context menu are timing out

After 267124@main (bug#260356).

Buildbot: builder WinCairo-64-bit-Release-Tests build 1905 (267125@main)
https://build.webkit.org/#/builders/728/builds/1905

Regressions: Unexpected timeouts (17)
  editing/selection/5354455-1.html [ Timeout ]
  editing/selection/5354455-2.html [ Timeout ]
  editing/selection/button-right-click.html [ Timeout ]
  editing/selection/context-menu-on-text.html [ Timeout ]
  editing/selection/context-menu-text-selection-lookup.html [ Timeout ]
  editing/selection/context-menu-text-selection.html [ Timeout ]
  editing/selection/empty-cell-right-click.html [ Timeout ]
  editing/selection/minimal-user-select-crash.html [ Timeout ]
  fast/events/context-no-deselect.html [ Timeout ]
  fast/events/context-nodrag.html [ Timeout ]
  fast/events/context-onmousedown-event.html [ Timeout ]
  fast/events/contextmenu-actions-in-selected-text.html [ Timeout ]
  fast/events/contextmenu-dismiss-blink-caret.html [ Timeout ]
  fast/events/contextmenu-lookup-action-for-image.html [ Timeout ]
  fast/events/contextmenu-scrolled-page-with-frame.html [ Timeout ]
  fast/events/right-click-focus.html [ Timeout ]
  fast/events/selectstart-prevent-selection-on-right-click.html [ Timeout ]
Comment 1 Fujii Hironori 2023-08-23 01:32:43 PDT 
Before the change, popup menu of context menu doesn't show.
After the change, a context menu shows by the following callstack.

> WebKit2.dll!WebKit::WebContextMenu::show() Line 55	C++
> WebKit2.dll!WebKit::WebFrame::handleContextMenuEvent(const WebCore::PlatformMouseEvent & platformMouseEvent) Line 1235	C++
> WebKit2.dll!WebKit::WebPage::contextMenuAtPointInWindow(WebCore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType,WTF::ObjectIdentifierMainThreadAccessTraits>> frameID, const WebCore::IntPoint & point) Line 3102	C++
> WebKit2.dll!WKBundlePageCopyContextMenuAtPointInWindow(const OpaqueWKBundlePage * pageRef, WKPoint point) Line 224	C++
> TestRunnerInjectedBundle.dll!WTR::EventSendingController::contextClick() Line 441	C++
> TestRunnerInjectedBundle.dll!WTR::JSEventSendingController::contextClick(const OpaqueJSContext * context, OpaqueJSValue * __formal, OpaqueJSValue * thisObject, unsigned __int64 argumentCount, const OpaqueJSValue * const * arguments, const OpaqueJSValue * * exception) Line 256	C++
> JavaScriptCore.dll!JSC::APICallbackFunction::callImpl<JSC::JSCallbackFunction>(JSC::JSGlobalObject * globalObject, JSC::CallFrame * callFrame) Line 61	C++
> JavaScriptCore.dll!JSC::callJSCallbackFunction(JSC::JSGlobalObject * globalObject, JSC::CallFrame * callFrame) Line 43	C++
> (...)

The context menu never closes. All tests time out.
Comment 2 Fujii Hironori 2023-08-23 17:28:51 PDT 
Created attachment 467406 [details]
WIP patch

The original code doesn't show a context menu for contextMenuAtPointInWindow.
How about this patch?
Comment 3 Radar WebKit Bug Importer 2023-08-29 14:11:16 PDT 
<rdar://problem/114659223>
Comment 4 Fujii Hironori 2023-08-29 14:35:24 PDT 

*** This bug has been marked as a duplicate of bug 260821 ***