Bug 260607 - [GStreamer][MSE] FastSeek is broken
Summary: [GStreamer][MSE] FastSeek is broken
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-23 06:24 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-09-07 07:36 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-08-23 06:24:33 PDT 
Seen in bug 260185.

With MSE, fastSeek is broken in that it never seek to the nearest keyframe and performs identical seek as a normal seek.

Additionally, in bug 260185, infrastructure has been put in place to make the seek operation asynchronous and to only complete once data has been received by the MediaSource.

This is a task that wasn't completed in 260185 for the sake of expediency.
Comment 1 Philippe Normand 2023-08-23 08:27:22 PDT 
I guess we should use this seek flag, GST_SEEK_FLAG_KEY_UNIT ...
Comment 2 Philippe Normand 2023-09-07 07:34:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17541
Comment 3 Philippe Normand 2023-09-07 07:36:02 PDT 
(In reply to Philippe Normand from comment #1)
> I guess we should use this seek flag, GST_SEEK_FLAG_KEY_UNIT ...

Strangely this broke the media/video-fast-seek.html test...

Anyways, I started a patch but couldn't find tests. media/media-source/media-source-fastseek.html is already passing, even with current main, AFAICS.