RESOLVED FIXED260719
REGRESSION(267278@main) [GStreamer] Stable builds broke with missing include and guard 
https://bugs.webkit.org/show_bug.cgi?id=260719
Summary REGRESSION(267278@main) [GStreamer] Stable builds broke with missing include ...
Lauro Moura
Reported 2023-08-25 10:03:51 PDT
Error due to missing include: In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-19.cpp:5: ../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp: In function ‘std::pair<GstAudioFormat, GstAudioLayout> WebCore::convertAudioSampleFormatToGStreamerFormat(const WebCore::AudioSampleFormat&)’: ../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:47:29: error: ‘U8’ is not a member of ‘WebCore::AudioSampleFormat’ 47 | case AudioSampleFormat::U8: | ^~ ../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:49:29: error: ‘S16’ is not a member of ‘WebCore::AudioSampleFormat’ 49 | case AudioSampleFormat::S16: ... And due to missing guard: ../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp: In member function ‘void WebCore::PlatformRawAudioData::copyTo(std::span<unsigned char>, WebCore::AudioSampleFormat, size_t, std::optional<long unsigned int>, std::optional<long unsigned int>, long unsigned int)’: ../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:195:25: error: ‘computeBytesPerSample’ was not declared in this scope 195 | auto size = computeBytesPerSample(format) * inputBuffer->n_samples; | ^~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:225:22: error: ‘computeBytesPerSample’ was not declared in this scope 225 | auto planeSize = computeBytesPerSample(format) * outputBuffer->n_samples; | ^~~~~~~~~~~~~~~~~~~~~ Fix incoming.
Attachments
Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2023-08-25 10:42:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17073
EWS
Comment 2 2023-08-25 12:35:03 PDT
Committed 267292@main (98a84f0a9a6b): <https://commits.webkit.org/267292@main> Reviewed commits have been landed. Closing PR #17073 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-08-25 12:36:17 PDT
<rdar://problem/114465606>
Note You need to log in before you can comment on or make changes to this bug.